Skip to content

[bot] Merge 26.3 to 26.5#634

Merged
github-actions[bot] merged 2 commits into
release26.5-SNAPSHOTfrom
26.5_fb_bot_merge_26.3
May 19, 2026
Merged

[bot] Merge 26.3 to 26.5#634
github-actions[bot] merged 2 commits into
release26.5-SNAPSHOTfrom
26.5_fb_bot_merge_26.3

Conversation

@github-actions
Copy link
Copy Markdown

Generated automatically.
Merging changes from: 335bfd9
Approve all matching PRs simultaneously.
Approval will trigger automatic merge.
Verify all PRs before approving: https://internal.labkey.com/Scrumtime/Backlog/harvest-gitOpenPullRequests.view?branch=26.5_fb_bot_merge_26.3

vagisha and others added 2 commits May 14, 2026 22:52
…tion, and Selenium tests (#622)

- `TestResultsSchema `extends UserSchema with DefaultSchema.registerProvider() registration, FK lookup columns, and wrapAllColumns() in createTable()
  - _Post-deploy_: Delete external schema on skyline.ms since the code-level registration now supersedes it. 
- Added form classes replacing all request.getParameter() calls across all actions
- Integer/Boolean for optional form parameters with null guards and descriptive error messages
- ParseException handling with SimpleErrorView for date parameters
- `cause` field added to error API responses; JSP alert messages updated to display it
- Added addNavTrail overrides to prevent missing page title warnings
- New `TestResultsTest` Selenium test class covering begin page, show run, run lookup, user runs, long-term trends, failures, flagging, and training data workflows
  - `BeginAction` (rundown page, date navigation, viewType selector)
  - `ShowRunAction` (run detail, pass sorting)
  - `ShowUserAction` (user page, date range)
  - `LongTermAction` (viewType selector)
  - `ShowFailuresAction` (failure detail, viewType selector)
  - `FlagRunAction` / `ShowFlaggedAction` (flag/unflag workflow)
  - `TrainRunAction` / `TrainingDataViewAction` (add/remove training set workflow)
  - `ViewLogAction` (view run log)
  - `ViewXMLAction` (view run XML)
  - `ChangeBoundariesAction` (update warning/error boundaries)
  - `SetUserActiveAction` (activate/deactivate user)
  - `DeleteRunAction` (delete a run)
- Replaced deprecated `javax.management.modelmbean.XMLParseException` with `IllegalArgumentException`
- Switched from `org.springframework.util.StringUtils` to `org.apache.commons.lang3.StringUtils`
@github-actions github-actions Bot merged commit 601d2dd into release26.5-SNAPSHOT May 19, 2026
7 checks passed
@github-actions github-actions Bot deleted the 26.5_fb_bot_merge_26.3 branch May 19, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants