Fb integration tests#40
Merged
Merged
Conversation
it prevents us from being able to use the Python Debugger in Intellij/PyCharm
- Remove global DISABLE_CSRF_CHECK - Explicitly define args/kwargs for ServerContext, effectively making create_server_context useless. Will deprecate and remove at a later date.
Users can now create and delete containers with the python API
labkey-nicka
approved these changes
Aug 28, 2020
Contributor
labkey-nicka
left a comment
labkey-nicka
left a comment
There was a problem hiding this comment.
Looks good. Ran locally as well as in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This adds integration tests to point python tests at a live server (in the past, python unit tests have been mocked)
Related Pull Requests
n/a
Changes
adds fixtures and an 'integration' suite