WebDav support#51
Merged
Merged
Conversation
Contributor
Author
|
@labkey-nicka @cnathe I tested this locally with embedded tomcat, but have not tested using a server that has a context path. I am fairly certain I got this right but would be good to have someone test with a context path set on their LKS instance. |
labkey-nicka
approved these changes
Jun 29, 2022
Contributor
labkey-nicka
left a comment
labkey-nicka
left a comment
There was a problem hiding this comment.
Looks good and works well with my local testing. Here is the final script I utilized:
| def webdav_client(self, webdav_options: dict = None): | ||
| # We localize the import of webdav3 here so it is an optional dependency. Only users who want to use webdav will | ||
| # need to pip install webdavclient3 | ||
| from webdav3.client import Client |
Contributor
Author
There was a problem hiding this comment.
Yeah it's rare that his feature is useful, but it's powerful when used!
|
|
||
| client = Client(options) | ||
|
|
||
| if self._verify_ssl is False: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This PR adds two methods to our ServerContext: webdav_client and webdav_path, which create a WebDav Client and construct a LabkeyServer WebDav path.
Related Pull Requests
Changes
hostnameproperty to ServerContextbase_urlproperty to ServerContextwebdav_clientmethod to ServerContextwebdav_pathmethod to ServerContext