Issue 46618: respect sort keys in QuerySelect#1098
Merged
Conversation
labkey-alan
approved these changes
Feb 6, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This addresses Issue 46618 where QuerySelect-based dropdowns in our applications were not respecting the
<sortColumn>property that is definable on XML query metadata for a column. With these changes if a column has a sort key specified, as determined by the server, then the QuerySelect will skip doing a client-side sort of the results.Related Pull Requests
Changes
hasSortKeyproperty to theQueryColumnmodel. Now supported byquery-getQueryDetails.api.formatSavedResultsandformatResultswhen processing results ofQuerySelectqueries.