Issue 46465: Grid actions that use a selectionKey doesn't get expected selections when filters applied to grid#1112
Merged
Merged
Conversation
…d selections when filters applied to grid - make sure setSnapshotSelections() is called before selectionKey based call to getSampleOperationConfirmationData()
labkey-susanh
approved these changes
Feb 16, 2023
cnathe
added
TeamCity test review complete
and removed
needs TeamCity test review
labels
# Conflicts: # packages/components/package.json # packages/components/releaseNotes/components.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
https://www.labkey.org/home/Developer/issues/issues-details.view?issueId=46465
When you are on a sample type grid in the app and you make a selection after adding filters to the grid, the create picklist and add picklist menu options aren't pulling through the correct selections via the selectionKey. This PR fixes that issue (which was fixed for other grid menu actions for issue 47257)
Related Pull Requests
Changes