Fix some DbCache-related test failures#5522
Merged
Merged
Conversation
labkey-adam
requested review from
labkey-jeckels,
labkey-klum and
labkey-matthewb
labkey-jeckels
approved these changes
May 23, 2024
This was referenced May 23, 2024
Merged
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Some test failures cropped up after merging the DbCache -> DatabaseCache migration PR
Related Pull Requests
Changes
deleteAllSpecimenData()to the specimen module so it could easily invalidate the new caches, which live in specimen. However, study still included the specimen importers, which meant distributions without the specimen module would import but never delete specimen data. Instead of moving the delete back to study, I moved all the import code into specimen.