Dropping an index requires callers to provide its name#6633
Merged
Conversation
…lely for implementation purposes
labkey-susanh
approved these changes
May 6, 2025
…class" This reverts commit 1a8e331.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Stop guessing index names (step 1). This change eliminates the
ChangeType.DropIndicesoption, which guessed the index name based on table and column names, leavingDropIndicesByNameas the only option. It also addsStorageProvisioner.dropIndices()to drop indices by name and adjustsAbstractAuditTypeProviderto use this method.Unfortunately, this does not eliminate all index name guessing: Admin-requested indexes (via metadata XML and domain save API) still create diffs using index names; we need to update this code path to use the audit provider app. Also, the SQL Server dialect still guesses names when updating the data type of a column that's part of an index. But this change is a step in the right direction.
https://www.labkey.org/home/Developer/issues/issues-details.view?issueId=52913