Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/org/labkey/test/tests/AbstractAssayTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,11 @@ protected void setupEnvironment()
_containerHelper.createProject(getProjectName(), null);
goToProjectHome(getProjectName());

// Some test use a stand alone specimen file. Before the file can be imported the Specimen module needs to be enabled.
_containerHelper.enableModule("Specimen");
if (_studyHelper.isSpecimenModulePresent())
{
// Some test use a stand alone specimen file. Before the file can be imported the Specimen module needs to be enabled.
_containerHelper.enableModule("Specimen");
}

log("Setting up groups, users and initial permissions");
ApiPermissionsHelper permissionsHelper = new ApiPermissionsHelper(this);
Expand Down
3 changes: 1 addition & 2 deletions src/org/labkey/test/tests/AliquotTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
import org.labkey.test.Locator;
import org.labkey.test.Locators;
import org.labkey.test.TestTimeoutException;
import org.labkey.test.categories.Daily;
import org.labkey.test.categories.Specimen;
import org.labkey.test.components.html.BootstrapMenu;
import org.labkey.test.components.html.OptionSelect;
Expand All @@ -32,7 +31,7 @@

import java.io.File;

@Category({Daily.class, Specimen.class})
@Category({Specimen.class})
@BaseWebDriverTest.ClassTimeout(minutes = 8)
public class AliquotTest extends SpecimenBaseTest
{
Expand Down
3 changes: 1 addition & 2 deletions src/org/labkey/test/tests/SpecimenCustomizeTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
import org.labkey.test.BaseWebDriverTest;
import org.labkey.test.Locator;
import org.labkey.test.TestFileUtils;
import org.labkey.test.categories.Daily;
import org.labkey.test.categories.Specimen;
import org.labkey.test.components.CustomizeView;
import org.labkey.test.components.DomainDesignerPage;
Expand All @@ -38,7 +37,7 @@
import java.util.Arrays;
import java.util.List;

@Category({Daily.class, Specimen.class})
@Category({Specimen.class})
@BaseWebDriverTest.ClassTimeout(minutes = 7)
public class SpecimenCustomizeTest extends SpecimenBaseTest
{
Expand Down
3 changes: 1 addition & 2 deletions src/org/labkey/test/tests/SpecimenExportTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
import org.labkey.test.Locator;
import org.labkey.test.TestFileUtils;
import org.labkey.test.TestTimeoutException;
import org.labkey.test.categories.Daily;
import org.labkey.test.categories.Specimen;
import org.labkey.test.util.FileBrowserHelper;
import org.labkey.test.util.LogMethod;
Expand All @@ -30,7 +29,7 @@

import static org.junit.Assert.assertTrue;

@Category({Daily.class, Specimen.class})
@Category({Specimen.class})
@BaseWebDriverTest.ClassTimeout(minutes = 6)
public class SpecimenExportTest extends SpecimenBaseTest
{
Expand Down
3 changes: 1 addition & 2 deletions src/org/labkey/test/tests/SpecimenGridExportTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import org.labkey.test.Locator;
import org.labkey.test.TestTimeoutException;
import org.labkey.test.WebTestHelper;
import org.labkey.test.categories.Daily;
import org.labkey.test.categories.Specimen;
import org.labkey.test.util.AbstractDataRegionExportOrSignHelper.ColumnHeaderType;

Expand All @@ -33,7 +32,7 @@
/**
* Test exporting rows from a specimen grid (not folder/study specimen export.)
*/
@Category({Daily.class, Specimen.class})
@Category({Specimen.class})
@BaseWebDriverTest.ClassTimeout(minutes = 7)
public class SpecimenGridExportTest extends AbstractExportTest
{
Expand Down
3 changes: 1 addition & 2 deletions src/org/labkey/test/tests/SpecimenImportTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
import org.labkey.test.BaseWebDriverTest;
import org.labkey.test.Locator;
import org.labkey.test.WebTestHelper;
import org.labkey.test.categories.Daily;
import org.labkey.test.categories.Specimen;
import org.labkey.test.components.ext4.RadioButton;
import org.labkey.test.util.DataRegionTable;
Expand All @@ -43,7 +42,7 @@

import static org.junit.Assert.assertEquals;

@Category({Daily.class, Specimen.class})
@Category({Specimen.class})
@BaseWebDriverTest.ClassTimeout(minutes = 5)
public class SpecimenImportTest extends SpecimenBaseTest
{
Expand Down
3 changes: 1 addition & 2 deletions src/org/labkey/test/tests/SpecimenMultipleImportTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,13 @@
import org.junit.experimental.categories.Category;
import org.labkey.test.BaseWebDriverTest;
import org.labkey.test.Locator;
import org.labkey.test.categories.Daily;
import org.labkey.test.categories.Specimen;
import org.labkey.test.util.LogMethod;
import org.labkey.test.util.StudyHelper;

import java.io.File;

@Category({Daily.class, Specimen.class})
@Category({Specimen.class})
@BaseWebDriverTest.ClassTimeout(minutes = 6)
public class SpecimenMultipleImportTest extends StudyBaseTest
{
Expand Down
3 changes: 1 addition & 2 deletions src/org/labkey/test/tests/SpecimenTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
import org.labkey.test.Locators;
import org.labkey.test.TestTimeoutException;
import org.labkey.test.WebTestHelper;
import org.labkey.test.categories.Daily;
import org.labkey.test.categories.Specimen;
import org.labkey.test.components.CustomizeView;
import org.labkey.test.components.dumbster.EmailRecordTable;
Expand Down Expand Up @@ -59,7 +58,7 @@
import static org.labkey.test.pages.study.specimen.ManageNotificationsPage.SpecimensAttachment;
import static org.labkey.test.util.DataRegionTable.DataRegion;

@Category({Daily.class, Specimen.class})
@Category({Specimen.class})
@BaseWebDriverTest.ClassTimeout(minutes = 20)
public class SpecimenTest extends SpecimenBaseTest
{
Expand Down
13 changes: 10 additions & 3 deletions src/org/labkey/test/tests/StudyBaseTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
public abstract class StudyBaseTest extends BaseWebDriverTest
{
protected static final File ARCHIVE_TEMP_DIR = StudyHelper.getStudyTempDir();

protected int datasetCount = getDatasetCount();
protected int visitCount = 65;

Expand Down Expand Up @@ -130,13 +131,19 @@ protected void startSpecimenImport(int completeJobsExpected)

protected void startSpecimenImport(int completeJobsExpected, File specimenArchive)
{
_specimenImporter = new SpecimenImporter(new File(StudyHelper.getStudySubfolderPath()), specimenArchive, ARCHIVE_TEMP_DIR, getFolderName(), completeJobsExpected);
_specimenImporter.startImport();
if (_studyHelper.isSpecimenModulePresent())
{
_specimenImporter = new SpecimenImporter(new File(StudyHelper.getStudySubfolderPath()), specimenArchive, ARCHIVE_TEMP_DIR, getFolderName(), completeJobsExpected);
_specimenImporter.startImport();
}
}

protected void waitForSpecimenImport()
{
_specimenImporter.waitForComplete();
if (_studyHelper.isSpecimenModulePresent())
{
_specimenImporter.waitForComplete();
}
}

protected void setExpectSpecimenImportError(boolean expected)
Expand Down
17 changes: 12 additions & 5 deletions src/org/labkey/test/tests/TabTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,8 @@ private void doTestContainerTabConversion()
goToProjectHome();
_containerHelper.createSubfolder(getProjectName(), COLLAB_FOLDER, "Collaboration");
_containerHelper.createSubfolder(COLLABFOLDER_PATH, STUDY_FOLDER_TAB_NAME, "Study");
_containerHelper.enableModule("Specimen");
if (_studyHelper.isSpecimenModulePresent())
_containerHelper.enableModule("Specimen");
_containerHelper.createSubfolder(COLLABFOLDER_PATH, ASSAY_FOLDER_TAB_NAME, "Assay");
clickFolder(COLLAB_FOLDER);
clickFolder(STUDY_FOLDER_TAB_NAME);
Expand Down Expand Up @@ -317,8 +318,11 @@ private void doTestContainerTabConversion()
clickAndWait(Locator.linkWithText(STUDY_FOLDER_TAB_LABEL));
assertTextPresent("Study Overview");
studyContainerTab = PortalTab.finder(getDriver()).withTabText(STUDY_FOLDER_TAB_LABEL).find();
studyContainerTab.goToTabContainer("Specimen Data");
assertTextPresent("Vial Search", "Import Specimens");
if (_studyHelper.isSpecimenModulePresent())
{
studyContainerTab.goToTabContainer("Specimen Data");
assertTextPresent("Vial Search", "Import Specimens");
}
clickAndWait(Locator.linkWithText(ASSAY_FOLDER_TAB_LABEL));
assertTextPresent("Assay List", EXTRA_ASSAY_WEBPART);

Expand All @@ -343,8 +347,11 @@ private void doTestContainerTabConversion()
assertTextPresent(STUDY_FOLDER_TAB_LABEL, ASSAY_FOLDER_TAB_LABEL);
clickAndWait(Locator.linkWithText(STUDY_FOLDER_TAB_LABEL));
assertTextPresent("Study Overview");
PortalTab.find(STUDY_FOLDER_TAB_LABEL, getDriver()).goToTabContainer("Specimen Data");
assertTextPresent("Vial Search", "Import Specimens");
if (_studyHelper.isSpecimenModulePresent())
{
PortalTab.find(STUDY_FOLDER_TAB_LABEL, getDriver()).goToTabContainer("Specimen Data");
assertTextPresent("Vial Search", "Import Specimens");
}
PortalTab.find(ASSAY_FOLDER_TAB_LABEL, getDriver()).activate();
assertTextPresent("Assay List", EXTRA_ASSAY_WEBPART);

Expand Down
5 changes: 3 additions & 2 deletions src/org/labkey/test/tests/flow/FlowSpecimenTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@
*/
package org.labkey.test.tests.flow;

import org.junit.Assume;
import org.junit.BeforeClass;
import org.junit.Test;
import org.junit.experimental.categories.Category;
import org.labkey.test.BaseWebDriverTest;
import org.labkey.test.Locator;
import org.labkey.test.WebTestHelper;
import org.labkey.test.categories.Daily;
import org.labkey.test.categories.Flow;
import org.labkey.test.categories.Specimen;
import org.labkey.test.components.assay.AssayConstants;
Expand All @@ -38,7 +38,7 @@
/**
* This test checks the flow specimen foreign key behavior from flow.FCSFiles and flow.FCSAnalyses.
*/
@Category({Daily.class, Flow.class, Specimen.class})
@Category({Flow.class, Specimen.class})
@BaseWebDriverTest.ClassTimeout(minutes = 8)
public class FlowSpecimenTest extends BaseFlowTest
{
Expand All @@ -62,6 +62,7 @@ public static void initFlowFolders()
@LogMethod
private void initializeStudyFolder()
{
Assume.assumeTrue("Specimen module not present", _studyHelper.isSpecimenModulePresent());
log("** Initialize Study Folder");
_containerHelper.createSubfolder(getProjectName(), getProjectName(), STUDY_FOLDER, "Study", null);
_containerHelper.enableModule("Specimen");
Expand Down
22 changes: 13 additions & 9 deletions src/org/labkey/test/tests/viability/AbstractViabilityTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ protected void initializeStudyFolder(String... tabs)
{
log("** Initialize Folder");
_containerHelper.createProject(getProjectName(), null);
_containerHelper.enableModule("Specimen");
if (_studyHelper.isSpecimenModulePresent())
_containerHelper.enableModule("Specimen");
_containerHelper.createSubfolder(getProjectName(), getProjectName(), getFolderName(), "Study", tabs, true);

log("** Create Study");
Expand All @@ -86,14 +87,17 @@ protected void importSpecimens()

protected void importSpecimens(String studyFolder, File specimensPath)
{
log("** Import specimens");
clickFolder(studyFolder);
clickAndWait(Locator.linkWithText("Specimen Data"));
waitAndClickAndWait(Locator.linkWithText("Import Specimens"));
waitForElement(Locator.id("tsv"));
setFormElement(Locator.id("tsv"), TestFileUtils.getFileContents(specimensPath));
submit();
assertTextPresent("Specimens uploaded successfully");
if (_studyHelper.isSpecimenModulePresent())
{
log("** Import specimens");
clickFolder(studyFolder);
clickAndWait(Locator.linkWithText("Specimen Data"));
waitAndClickAndWait(Locator.linkWithText("Import Specimens"));
waitForElement(Locator.id("tsv"));
setFormElement(Locator.id("tsv"), TestFileUtils.getFileContents(specimensPath));
submit();
assertTextPresent("Specimens uploaded successfully");
}
}

protected void createViabilityAssay()
Expand Down