Skip to content

Accessibility: Components page QueryGrid test locator fixes #3014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cnathe merged 1 commit into from
May 22, 2026
Merged

Accessibility: Components page QueryGrid test locator fixes #3014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/org/labkey/test/components/ui/grids/QueryGrid.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,7 +815,7 @@ public List<FilterStatusValue> getFilterStatusFilterValues()
return new FilterStatusValue.FilterStatusValueFinder(getDriver()).findAll(filterStatusPanel);
}

final WebElement removeAllFilters = Locator.tagWithClass("a", "remove-all-filters").refindWhenNeeded(this);
final WebElement removeAllFilters = Locator.byClass("remove-all-filters").refindWhenNeeded(this);

// The panel header element which will contain the edit status text, the view name and the Save & Undo buttons.
// If this is the default view this will not be present.
Expand Down
2 changes: 1 addition & 1 deletion src/org/labkey/test/pages/core/login/CompactFileUploadField.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ protected class ElementCache extends Component<?>.ElementCache
WebElement logoFileInput = Locator.tagWithClass("input", "file-upload__input")
.refindWhenNeeded(this).withTimeout(4000);

WebElement removeBtn = Locator.tagWithClass("span", "attached-file__remove-icon")
WebElement removeBtn = Locator.tagWithClass("button", "attached-file__remove-icon")
.refindWhenNeeded(this).withTimeout(4000);

Locator attachedFile(File file)
Expand Down