feat: add v1 spec#1
Conversation
|
@adsharma could you PTAL? |
| ``` | ||
|
|
||
| ### Initialization script | ||
| A script (typically containing node and relationship table creation rules) that can be executed by the query engine to create the graph in the database. This script is responsible for creating the graph structure, including node tables and relationship tables, and performing necessary validations. |
There was a problem hiding this comment.
create the graph in the database
Creates metadadata. Data stays in parquet files. Could be remote (in object storage)
| name STRING, | ||
| age INT | ||
| ) WITH ( | ||
| format = 'parquet', |
There was a problem hiding this comment.
format could be optional. Could be inferred from the other parameter
| age INT | ||
| ) WITH ( | ||
| format = 'parquet', | ||
| file_path = 'path/to/node_table_1.parquet' |
There was a problem hiding this comment.
a URL could be more appropriate here, since it could be a s3://... like URL and anything supported by VFS. Would love to see XET here as well, since some of our datasets live on huggingface.
This is currently called STORAGE. There is some cost to renaming it - so I'd leave it alone if its not the most important thing.
| name STRING, | ||
| age INT | ||
| ) WITH ( | ||
| format = 'arrow', |
There was a problem hiding this comment.
Also suggest merging the two into a single url. Previous comment about STORAGE applies here as well.
|
@adsharma can we rid of init script and metadata file from the spec? Because these are completely impl specific. We are not really specifying anything here |
|
Re: comments on examples @adsharma those are just examples to show the tables / metadata might look, not really an impl of the spec. I will create a baseline impl, which would be based on ladybugDB impl, in a future PR |
This whole spec is modeled after DuckLake. Specification: https://ducklake.select/docs/stable/specification/introduction If we're going to spend some time writing specs, it makes sense to specify what data types are valid in |
It's not clear that another impl needs to live in this repo. If lets say Grafeo or ArcadeDB want to implement this spec, the impl could live in their respective repos. |
Initially, I had the same idea, but I was concerned about the helper scripts like |
isn't icebug-format about graph storage rather than full-fledged graph database 🤔 . How queries are executed is part of query engine right? |
Now I imagine a similar |
got it now. Changes in the latest commit |
added v1 specs for memory and disk