[WIP] Add icebug mem impl#496
Conversation
|
I realize this is not ready for review. But thanks for sharing it early for feedback! Two high level concerns and details:
Recommendations:
|
Brand names tend to change far less frequently than technical details, wouldn’t you agree? Perhaps only on rare occasions. Also, if we were to name it
There is already a significant amount of redundant state and data in both the table and scan state classes due to inheritance from the native classes. For instance, if you look at Even with the
didn't get this part |
The Tag in this context is TRIPLES or CSR (feel free to rename). The status right now:
In the future there may be a legit use case for running cypher over a triple table stored in parquet (we support this for duckdb/sqlite/postgres). I'm thinking about how to implement this matrix with the most code reuse and maintainability. I agree that sometimes its necessary to duplicate code for clarity. Inheritance is not the best way to share code etc. But I'm not convinced that we should have 4 cases above * {node, rel} = 8 classes. |
Closes: #329