Rewrite App Profiling Insights docs as a dashboard reference; add the Comparison tab, p90 views and threshold alerts - #3198
Closed
hardikshah197 wants to merge 5 commits into
Conversation
…for App Profiling Insights
Adds a Comparison section to the App Profiling Insights page covering the session-level overlay view: what it is for, the end-to-end flow, the Test Sessions rail and its filters, how the charts are drawn, the baseline and Baseline Diff behaviour, and what gets saved between visits. - Notes the two tabs under "How to access" and cross-links Comparison. - Explains the elapsed-time X-axis, which is what distinguishes these charts from the calendar-time charts on Trends. - Documents the five-session cap and the at-least-one-selected rule. - Records that the rail filters, selected sessions, baseline, Baseline Diff and hidden series are auto-saved per test at org level, while the date range is owned by the shared page picker and is not part of the saved comparison. - Updates "Sharing a dashboard": the URL now round-trips the active tab. - Adds session comparison / baseline diff keywords and mentions Comparison in the page description. Three screenshots captured from a live Android profiling test: the overlaid view with the stats table, the rail with the More filter menu open, and the Startup Time card showing Cold/Hot bars, SLA lines and baseline deltas.
…s to WebP Addresses the two self-review findings. Average / p90: - The toggle lives in the Trends top bar, not "every widget on the dashboard". It is rendered only when the Comparison tab is inactive, so the old wording became wrong the moment this page documented a second tab. - Adds "Which one to read" — what each aggregation answers, a table of when to reach for which, and the point that Average and p90 sitting close together is itself a signal the metric is stable. - Records how p90 is actually derived: the mean of each session's own pre-computed 90th percentile, not the percentile of the whole window. Notes which metrics have no p90 and render as an em dash (cold/hot startup, crash and ANR counts) and why frozen/janky frames stay on their average. - Adds "p90 on the Comparison tab": there is no toggle there and the Trends toggle does not carry across. Every Comparison stats table reports Avg, Min, Max and P90 together for each selected session, which is the more useful shape for individual runs. Cross-linked from the Comparison section. Screenshots: - Convert the three Comparison PNGs to WebP: 1.2 MB -> 220 KB. WebP is the dominant format in this directory (72 files vs 40 PNG) and the comparable app-profiling-screenshot.webp is 120 KB, so the PNGs were ~10x heavier than convention. Text remains legible at quality 82.
Both were caught re-reading the doc against the reducer. Auto-selection: the doc said "the run you opened is selected automatically". pickAutoSelection sorts the filtered sessions byNewest and takes the first, and the URL's testId is never passed down to the Comparison component — so opening the dashboard from an older run and switching to Comparison selects a different session than the doc promised. Reworded to "the most recent run of that test", with the caveat spelled out. Rail ordering: the doc said "newest first". buildOrderedSessions returns [...picked, ...rest], so sessions selected for comparison are pinned to the top and only the remainder is newest-first. A reader selecting an older run and watching it jump to the top would otherwise think the sort was broken. Also expands the Clear Filters row while in the same table: it resets the comparison to the test's most recent run as well as resetting the filters, and the date range is preserved because it belongs to the shared picker.
…d site_name
Images — all six the page references are now WebP and under 100 KB:
- Convert the email and Slack alert screenshots from PNG to WebP at quality 88;
264 KB -> 80 KB and 192 KB -> 60 KB. Checked at full size first: the threshold
values, per-metric deltas and the footer URL all stay legible.
- app-profiling-screenshot.webp was 120 KB. Re-encoding an already-lossy WebP
made it larger, so the lever was its size: it was 1825 px wide but rendered at
768. Downscaled to 1200 px (still ~1.6x for retina) -> 84 KB.
- That image's height attribute said 373 for a 1.29 aspect ratio, which never
matched and would shift the layout as it loads. Corrected to 594.
Meta description trimmed from 297 to 159 characters. Note the first attempt
started "App Profiling Insights: CPU, ..." — the colon-space made the front
matter invalid YAML and would have broken the page build, so the wording avoids
the colon rather than quoting around it.
site_name: LambdaTest -> TestMu AI, matching the url and canonical fields that
already point at testmuai.com.
Removes both {/* TODO screenshot */} placeholders. The p90 one is obsolete now
that the section documents the toggle in prose; the KPI-selector one was the
same class of leftover.
Contributor
Author
|
Superseded — reopening against the correct release branches. This PR targeted Replaced by, with identical content:
Closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrites the App Profiling Insights page as a reference for what the dashboard actually does, and documents the new Comparison tab.
The previous version was advisory rather than descriptive — sections like Advanced Analysis Techniques, Correlation Analysis, Performance Budgeting and Continuous Monitoring explained performance practice in general but did not tell a reader what any control on the page does. It is replaced with a walkthrough of the real UI: how to reach it, every filter, every widget, the SLA model, and the alerts.
What the page now covers
Comparison tab
A new section documenting the session-level overlay view, placed after Compare mode so the two "compare" concepts sit together and can be told apart — one overlays dimensions on a single widget, the other overlays whole test sessions.
The framing the section leads with: Trends charts calendar time, Comparison charts elapsed time within each run — every session starts at
0:00. That is what lets runs of different lengths and start times be read against one another, and it is the thing a reader needs before the charts make sense.Screenshots
Five images. Two for the alert formats, and three new ones captured from a live Android profiling test with three sessions overlaid:
app-profiling-comparison.pngapp-profiling-comparison-filters.pngapp-profiling-comparison-startup.pngAll three were reviewed before committing: they show test names, truncated Test IDs and device models only — no email, org name or account details.
Notes for review
#comparisoncross-link rather than pinning an explicit{#comparison}id, because no other doc in this repo uses that syntax andonBrokenAnchorsis not configured (it defaults to warn, not throw). Worth a second opinion if you'd prefer the explicit form.{/* TODO screenshot: ... */}placeholders remain, for the Average/p90 toggle and the Performance Trends KPI selector. They are comments, not broken image references, but they are still open.