Stage->Prod - #547
Merged
Merged
Conversation
… hang the build On rate-limited/WAF-protected sites the target can crash mid-capture (page.goto: Page crashed / setViewportSize: Target crashed). page.close()/context.close() then never resolve on the dead target, so the capture promise never settles, Promise.allSettled never returns and finalizeBuild is unreachable — the build stays 'running' until the job times out (seen as ~30 minute scans). Evidence from an instrumented run: 12 'closing page/context' vs 11 'page/context closed'. Race the teardown against BROWSER_CLOSE_TIMEOUT (15s) and continue if it does not return; closeBrowsers() force-kills the browser process afterwards. Scope: this fixes only the hang, so the build completes quickly. Screenshots may still show Access Denied after the first few captures — that is the customer's WAF rate limiting and is resolved only once the HYE VMs are whitelisted. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
fix(TE-23055): bound page/context teardown so a crashed target cannot hang the web scanner build
parthlambdatest
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.