fix: generate mock for object without dictionary#55
Merged
RicherStAmand merged 3 commits intoApr 24, 2024
Conversation
RicherStAmand
changed the base branch from
master
to
fix/SP-10428-generate-type-for-object-without-dictionnary
RicherStAmand
requested review from
MathieuMathurin,
SimonDrouin and
jeremidallaire-landr
MathieuMathurin
approved these changes
Apr 24, 2024
RicherStAmand
merged commit 595780a
into
fix/SP-10428-generate-type-for-object-without-dictionnary
RicherStAmand
deleted the
fix/SP-10428-generate-mock-for-object-without-dictionnary
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #52
Now that types generator consider additional properties that do not have dictionary, we got a typing issue with the mocks.
Before
After
This PR generate mocks that comply with the generated types