fix: Fixes #157 prevent crash if polkadot.js ext includes evm acct -M11#158
Merged
poppyseedDev merged 1 commit intoLasticXYZ:mainfrom May 21, 2024
Merged
fix: Fixes #157 prevent crash if polkadot.js ext includes evm acct -M11#158poppyseedDev merged 1 commit intoLasticXYZ:mainfrom
poppyseedDev merged 1 commit intoLasticXYZ:mainfrom
Conversation
…ludes evm accounts
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
Sorry that this took so long to test, but it turns out polkadot js extension doesn't allow you to add your an evm account so easily, what I had to do to make it work is to create an account on moonriver export it and then import it on polkadot js. But the PR works well: 
Let me know your wallet address so we can send you 50$ in DOT or BTC :) |
poppyseedDev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of crashing when clicking to connect Polkadot.js Extension and it includes an EVM address, and instead of just ignoring it by returning an empty
<div></div>this PR proposes to still list the EVM address but prevent the user from clicking in in the account list, and highlight it in red.A better alternative could be to not use
AiOutlineMeh, and replace lines 142-154 with just areturn (<div></div>)Closes #157