Updates to Accommodate React Router 6#43
Open
mwislek wants to merge 5 commits into
Open
Conversation
mwislek
commented
May 10, 2025
| `./${subSectionName}/views/${pascalCaseName}Show.jsx` | ||
| ) | ||
| ) | ||
| // Rename routes file |
Contributor
Author
There was a problem hiding this comment.
The real change was here. The rest of these changes were formatting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the client template subsection generator to accommodate React Router 6. See https://github.com/LaunchPadLab/client-template/pull/485 for the client changes that prompted this update.
To test this:
feat/react-router-6branch.yarn linkin the root of this projectclient-templaterepository and pull the latest from themainbranch.yarn link "@launchpadlab/lp-subsection-generator"to use the local subsection generatoraccountssubsection executeyarn generate-subsection accountsin the client-template project root folder.<AppRouter>component.a. You can navigate to the new
accountssubsection, i.e.,http://localhost:8080/accountsb. That the accounts index view is displayed
c. You can navigate to the a specific account, i.e.,
http://localhost:8080/accounts/3d. That the accounts show view is displayed.
/homeroute is still functional./styleguideis still functional.