Skip to content

ci(github): optimize workflow triggers for draft PRs#215

Merged
j-d-ha merged 3 commits into
mainfrom
fix/set-actions-to-run-when-ready-for-review
Dec 4, 2025
Merged

ci(github): optimize workflow triggers for draft PRs#215
j-d-ha merged 3 commits into
mainfrom
fix/set-actions-to-run-when-ready-for-review

Conversation

@j-d-ha

@j-d-ha j-d-ha commented Dec 4, 2025

Copy link
Copy Markdown
Collaborator

🚀 Pull Request

📋 Summary

This PR optimizes GitHub Actions workflows to avoid unnecessary CI runs on draft pull requests. The changes update workflow triggers to only execute when PRs are ready for review and improve concurrency handling.

Key changes:

  • Updated workflow event triggers to include ready_for_review type
  • Added conditional check to skip docs workflow for draft PRs
  • Changed docs workflow concurrency to allow cancellation
  • Updated code cleanup and formatting rules in JetBrains settings

✅ Checklist

  • My changes build cleanly
  • I've added/updated relevant tests
  • I've added/updated documentation or README
  • I've followed the coding style for this project
  • I've tested the changes locally (if applicable)

🧪 Related Issues or PRs

N/A - Internal workflow optimization


💬 Notes for Reviewers

This PR improves CI efficiency by:

  1. Preventing workflows from running on draft PRs until they're marked ready for review
  2. Allowing concurrent docs builds to be cancelled when new commits are pushed
  3. Standardizing workflow trigger types across all workflows

The JetBrains settings changes are primarily whitespace/formatting adjustments to the code cleanup profile.

…ehavior

- Added `ready_for_review` to pull request event types in multiple workflows.
- Enabled `cancel-in-progress` for the concurrency group in `docs.yaml`.
- Added condition to exclude draft pull requests from the build job in `docs.yaml`.
- Updated code cleanup settings to optimize imports and rearrange in multiple languages.
- Added several formatting rules for C# and XML, including brace and expression body styles.
- Enabled additional settings for keeping consistent code style and formatting arrangement.
@github-actions github-actions Bot added the type: ci CI/CD changes label Dec 4, 2025

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/docs.yaml Outdated
@codecov

codecov Bot commented Dec 4, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #215   +/-   ##
=======================================
  Coverage   90.92%   90.92%           
=======================================
  Files         102      102           
  Lines        2227     2227           
  Branches      252      252           
=======================================
  Hits         2025     2025           
  Misses        109      109           
  Partials       93       93           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1daba7d...441cf35. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Refined conditional logic to handle non-pull-request events correctly.
- Ensured draft PR exclusion remains intact for the build job.
@sonarqubecloud

sonarqubecloud Bot commented Dec 4, 2025

Copy link
Copy Markdown

@j-d-ha
j-d-ha merged commit 2849719 into main Dec 4, 2025
8 checks passed
@j-d-ha
j-d-ha deleted the fix/set-actions-to-run-when-ready-for-review branch December 4, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: ci CI/CD changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant