fix(core): adjust default timeout values and update documentation#226
Merged
Merged
Conversation
- Adjust `InitTimeout` default from 5 seconds to 500ms for Lambda initialization. - Ensures faster failure handling and improved responsiveness.
- Changed `InvocationCancellationBuffer` default from 3 seconds to 500ms. - Improves cancellation timing precision for Lambda function invocations.
- Changed `InitTimeout` default from 500ms to 5 seconds for `ILambdaOnInitBuilder.OnInit` handlers. - Provides more time for initialization tasks to complete successfully.
- Updated `InvocationCancellationBuffer` default value to 500ms in documentation. - Adjusted tables in dependency-injection and configuration guides for improved readability. - Standardized time unit formatting across tables (e.g., `500 ms` to `500ms`).
j-d-ha
changed the title
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #226 +/- ##
=======================================
Coverage 88.93% 88.93%
=======================================
Files 106 106
Lines 2277 2277
Branches 256 256
=======================================
Hits 2025 2025
Misses 160 160
Partials 92 92
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
j-d-ha
deleted the
docs/update-invocation-cancellation-buffer-default
branch
December 11, 2025 14:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
📋 Summary
Adjusts default timeout values in
LambdaHostOptionsfor better production behavior and updates documentation to reflect these changes.Changes included:
✅ Checklist
🧪 Related Issues or PRs
This PR consolidates timeout default adjustments and corresponding documentation updates to ensure consistency between code and docs.
💬 Notes for Reviewers
Code changes:
LambdaHostOptions.cs: Updated default values forInitTimeout(5s) andInvocationCancellationBuffer(500ms)Documentation changes:
docs/guides/configuration.md: Updated reference table to show correct defaultsdocs/guides/dependency-injection.md: Updated cancellation buffer tip textAll example configurations using custom values (like 5 seconds in examples) remain unchanged as they are intentional configuration examples.