chore: remove obsolete code and deprecated features#229
Merged
Conversation
…tions - Deleted `LambdaOpenTelemetryAdapters` to eliminate redundant tracing extension methods. - Removed associated unit tests for deprecated methods in `LambdaOpenTelemetryServiceProviderExtensionsTests`. - Deprecated methods have been replaced by the `UseOpenTelemetryTracing` API.
…property - Deleted `BootstrapHttpClient` property marked as obsolete. - The recommended replacement is `AddLambdaBootstrapHttpClient()` or `TryAddLambdaBootstrapHttpClient()`. - Aligns with planned removal in version 2.0.0.
…ent` handling - Eliminated code dependent on `BootstrapHttpClient` marked as obsolete. - Simplifies the constructor by directly using the injected `httpClient`. - Aligns with recent removal of `BootstrapHttpClient`.
…SyntaxProvider` - Deleted the `UseOpenTelemetryTracingSyntaxProvider` no longer in use. - Aligns with recent changes emphasizing simplified tracing integrations. - Ensures source generator code is streamlined and free of deprecated utilities.
…ilder syntax provider - Changed the `ContainingNamespace` from `AwsLambda.Host` to `MinimalLambda` for target operation. - Aligns with updated project structure and naming conventions.
…` handling - Removed `UseOpenTelemetryTracingInfos` from `CompilationInfo` model. - Deleted `UseOpenTelemetryTracingSyntaxProvider` references in `MapHandlerIncrementalGenerator`. - Cleaned up associated code to streamline source generator logic. - Aligns with recent tracing simplification efforts.
- Updated `VerifyTests` in unit test cases to remove redundant string argument. - Added generated snapshot files for `OnInit`, `OnShutdown`, and `ExpressionLambdaVerifyTests`. - Streamlines testing process by incorporating auto-generated code snapshots.
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #229 +/- ##
==========================================
+ Coverage 88.73% 89.61% +0.87%
==========================================
Files 106 104 -2
Lines 2273 2128 -145
Branches 256 253 -3
==========================================
- Hits 2017 1907 -110
+ Misses 165 129 -36
- Partials 91 92 +1
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
📋 Summary
This PR removes obsolete and deprecated code that was previously marked for removal in version 2.0.0, including deprecated OpenTelemetry adapter methods, unused source generator syntax providers, and the obsolete
BootstrapHttpClientproperty.Key changes:
GetOpenTelemetryTracer*extension methods fromLambdaOpenTelemetryAdapters.csUseOpenTelemetryTracingSyntaxProviderthat tracked deprecated method callsBootstrapHttpClientproperty fromLambdaHostOptionsBootstrapHttpClienthandling fromLambdaBootstrapAdapterLambdaApplicationBuilderBuildSyntaxProvider(fromAwsLambda.Host.BuildertoMinimalLambda.Builder)Impact:
✅ Checklist
🧪 Related Issues or PRs
N/A - General code cleanup of deprecated features
💬 Notes for Reviewers
This is a cleanup PR that removes code previously marked with
[Obsolete]attributes indicating removal in v2.0.0. All removed code had alternatives already in place, so this should be a straightforward removal.The verify test snapshots were added to ensure the source generator continues working correctly after removing the
UseOpenTelemetryTracingSyntaxProvider.