refactor(core): replace [Event] attribute with [FromEvent]#250
Merged
j-d-ha merged 3 commits intoDec 15, 2025
Merged
Conversation
- Updated handler registration examples and documentation to adopt `[FromEvent]` naming convention. - Adjusted source code, unit tests, and snapshots to reflect the replacement of the `[Event]` attribute. - Marked the `[Event]` attribute as obsolete and added a warning to nudge users towards `[FromEvent]`. - Verified correct handling and diagnostics to ensure one `[FromEvent]` annotation per Lambda handler.
- Updated version in Directory.Build.props from 2.0.0-beta.7 to 2.0.0-beta.8.
…mentation - Removed redundant `<code>` tag in the example usage of the `[Event]` attribute.
j-d-ha
changed the title
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #250 +/- ##
==========================================
- Coverage 88.31% 88.23% -0.09%
==========================================
Files 127 127
Lines 3013 2991 -22
Branches 337 337
==========================================
- Hits 2661 2639 -22
Misses 219 219
Partials 133 133
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
j-d-ha
deleted the
refactor/#249-deprecate-Event]-attribute-in-favor-of-FromEvent]
branch
December 15, 2025 17:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
📋 Summary
Deprecates the
[Event]attribute in favor of the new[FromEvent]attribute to follow .NET naming conventions and prevent conflicts withSystem.Diagnostics.Tracing.EventAttribute.Key changes:
[FromEvent]attribute as the recommended approach[Event]as obsolete with a descriptive message[FromEvent]✅ Checklist
🧪 Related Issues or PRs
Closes #249
💬 Notes for Reviewers
[Event]attribute remains functional (marked obsolete) to maintain backward compatibility[Event], guiding them to use[FromEvent]