refactor: consolidate code style and improve readability#291
Merged
Conversation
…s multiple files - Corrected inconsistent parameter formatting in constructors and method declarations. - Adjusted newline usage to ensure better readability and consistency in indentation. - Standardized the wrapping of multi-line argument values and initializer blocks. - Updated project references in .csproj files by removing unnecessary spaces for uniform formatting.
…ing across files - Adjusted multi-line wrapping for better alignment of object initializers and method arguments. - Unified indentation and newline usage in extensions, context factories, and test files. - Streamlined YAML task configuration for cleanup code.
- Adjusted multi-line wrapping in method declarations, initializers, and object arguments. - Normalized YAML formatting with new exclude/include properties for cleanup tasks. - Standardized package reference formatting in `Directory.Packages.props`. - Applied consistent wrapping and indentation in .cs and test files for readability.
…pping and indentation - Unified formatting in method declarations, attribute usage, and object initializers. - Improved line breaks and alignment across multiple files for better consistency. - Applied consistent indentation in test files and context factories to enhance clarity.
- Removed `csharpier` definition from `.config/dotnet-tools.json`. - Added new settings for LINQ query and multiline parameter alignment in `.DotSettings`. - Updated YAML formatting in `pr-build.yaml` for proper spacing and consistency. - Replaced `csharpier` formatting task with JetBrains cleanup code task in CI workflows.
github-actions
Bot
added
breaking-change
j-d-ha
changed the title
…tion - Updated test commands in workflows to improve readability and verbosity control. - Introduced `Directory.Build.props` for global .NET test configuration. - Applied consistent formatting for YAML test steps across `pr-build.yaml` and `main-build.yaml`.
- Removed an unnecessary blank line from the `pr-build.yaml` workflow file for better consistency.
- Added `xunit.runner.json` to configure test runs with `maxParallelThreads` set to 1. - Updated `.csproj` file to include `xunit.runner.json` with `CopyToOutputDirectory` set to `PreserveNewest`.
- Added `xunit.runner.json` to all test projects for uniform test configuration. - Updated corresponding `.csproj` files to include `xunit.runner.json` with `CopyToOutputDirectory` set to `PreserveNewest`.
- Added `test:ci` task in `TestTasks.yml` for running the complete CI test suite. - Updated `pr-build.yaml` and `main-build.yaml` to use `task test:ci` for test execution. - Removed redundant inline test commands in workflow files for better maintainability.
- Modified `FormattingTasks.yml` to update `--include` paths for CleanupCode. - Scoped paths to `src`, `test`, `examples`, and `benchmark` directories. - Excluded unnecessary `bin` and `obj` directories to improve task efficiency.
- Added `.sonarqube/**/*` and `codecov*` to `--exclude` paths in `FormattingTasks.yml`. - Ensures unnecessary directories are excluded from CleanupCode processing.
… .gitignore - Removed `--exclude` paths in `CleanupCode` task configuration for better maintainability. - Added `.sonarqube/` and `codecov*` entries to `.gitignore` to ensure proper file exclusion.
…ages.props` - Added space before self-closing slashes in `<PackageVersion>` tags for consistency. - Ensured uniform formatting across all package definitions.
…e unused dependencies - Removed unnecessary `coverlet.collector` package references from test projects. - Updated `<PackageVersion>` tag formatting in `Directory.Packages.props` for consistency.
…tory.Packages.props` - Added spaces before self-closing slashes in `<PackageVersion>` tags for consistency. - Ensured consistent tag formatting across all package definitions.
- Set `timeout-minutes` to 10 for primary job execution in `pr-build.yaml` and `main-build.yaml`. - Added `timeout-minutes` of 3 for the test step to prevent prolonged executions.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
📋 Summary
This PR consolidates and simplifies the codebase formatting standards, resulting in improved readability and consistency across all files.
Key Changes
.sln.DotSettingsfrom 140 lines to 48 lines, removing extensive cleanup profiles and keeping only essential formatting rulesDirectory.Build.propsandDirectory.Packages.propsMotivation
The previous ReSharper settings included comprehensive cleanup profiles with extensive language-specific configurations. This PR streamlines the configuration to focus on core C# formatting rules, making the codebase more maintainable while improving readability through better multi-line wrapping.
✅ Checklist
🧪 Related Issues or PRs
N/A - General code quality improvement
💬 Notes for Reviewers
This is a large-scale formatting change affecting 227 files. The changes are purely cosmetic and do not affect functionality:
The ReSharper settings simplification removes verbose cleanup profiles while maintaining the essential formatting rules. The actual code changes are primarily:
Recommend reviewing the ReSharper settings changes first (
MinimalLambda.sln.DotSettings) to understand the new baseline, then spot-checking a few representative files to verify formatting improvements.