fix(build): suppress NU5104 for preview TFM dependencies#337
Merged
Conversation
- Configure Dependabot to monitor Microsoft.Extensions.Http for major version updates.
- Added NU5104 to NoWarn property to ignore warnings for preview dependencies in net11.0.
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #337 +/- ##
==========================================
+ Coverage 87.38% 87.52% +0.14%
==========================================
Files 113 113
Lines 2814 2814
Branches 351 351
==========================================
+ Hits 2459 2463 +4
+ Misses 254 250 -4
Partials 101 101 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
📋 Summary
Suppresses NuGet warning NU5104 (
TreatWarningsAsErrors) which fires duringdotnet packbecause targetingnet11.0pulls in preview versions ofMicrosoft.Extensions.Hosting. This is intentional — the project explicitly supports thenet11.0preview TFM, so the preview dependency is expected.✅ Checklist
🧪 Related Issues or PRs
Closes #...
💬 Notes for Reviewers
Change is in
Directory.Build.props— applies globally to all packable projects.