Skip to content

fix: suppress net11 pack warning#361

Merged
j-d-ha merged 1 commit into
mainfrom
fix/suppress-net11-pack-warning
Jun 12, 2026
Merged

fix: suppress net11 pack warning#361
j-d-ha merged 1 commit into
mainfrom
fix/suppress-net11-pack-warning

Conversation

@j-d-ha

@j-d-ha j-d-ha commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Summary

Adds a root Directory.Build.targets pack-time suppression for NU5104 only when a project ships a net11.0 target. This lets stable package versions pack while .NET 11 dependencies are still preview-only.

Changes

  • Suppresses NU5104 when TargetFrameworks contains net11.0.
  • Keeps suppression scoped to net11-targeting packages instead of globally disabling prerelease dependency validation.

Validation

  • Ran dotnet pack --configuration Release --output /tmp/minimal-lambda-pack-test /p:Version=2.6.0 successfully.

Notes for Reviewers

  • Existing Directory.Build.props suppression only applied when TargetFramework == net11.0; pack fails in outer-build context where TargetFrameworks is available instead.

@github-actions github-actions Bot added the type: fix Bug fix label Jun 12, 2026
@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #361   +/-   ##
=======================================
  Coverage   87.38%   87.38%           
=======================================
  Files         113      113           
  Lines        2814     2814           
  Branches      351      351           
=======================================
  Hits         2459     2459           
  Misses        254      254           
  Partials      101      101           

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a4563f...694bc92. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@j-d-ha
j-d-ha merged commit 493e828 into main Jun 12, 2026
8 checks passed
@j-d-ha
j-d-ha deleted the fix/suppress-net11-pack-warning branch June 12, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant