fix: suppress net11 pack warning#361
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #361 +/- ##
=======================================
Coverage 87.38% 87.38%
=======================================
Files 113 113
Lines 2814 2814
Branches 351 351
=======================================
Hits 2459 2459
Misses 254 254
Partials 101 101 Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a root
Directory.Build.targetspack-time suppression forNU5104only when a project ships anet11.0target. This lets stable package versions pack while .NET 11 dependencies are still preview-only.Changes
NU5104whenTargetFrameworkscontainsnet11.0.Validation
dotnet pack --configuration Release --output /tmp/minimal-lambda-pack-test /p:Version=2.6.0successfully.Notes for Reviewers
Directory.Build.propssuppression only applied whenTargetFramework == net11.0; pack fails in outer-build context whereTargetFrameworksis available instead.