chore: use version ranges for conditional EF Core/Extensions packages#13
Merged
Conversation
Bounds each package to [pinned, nextMajor.0.0) instead of an exact version, consistent across every entry in both the net10.0 and net11.0 conditional groups. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 973aeb6e2f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
NuGet sorts a prerelease below its matching stable release, so an exclusive upper bound of 12.0.0 still admits 12.0.0-preview.* - it only excludes 12.0.0 stable and later, not previews of it. Using 12.0.0-0 (and 11.0.0-0 for the net10.0 block) as the upper bound instead excludes the entire next-major line, previews included. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Microsoft.EntityFrameworkCore.Relational) to the other fivePackageVersionentries in both thenet10.0andnet11.0conditionalItemGroups inDirectory.Packages.props[pinned, nextMajor.0.0)instead of an exact version, consistently across the whole blockTest plan
dotnet restore SharpMud.slnxsucceeds🤖 Generated with Claude Code