pkcs1_decode potential overflow issue #883 fix, check for error first#887
Closed
StevenEck wants to merge 1 commit intoLegrandin:masterfrom
Closed
pkcs1_decode potential overflow issue #883 fix, check for error first#887StevenEck wants to merge 1 commit intoLegrandin:masterfrom
StevenEck wants to merge 1 commit intoLegrandin:masterfrom
Conversation
…ror first Making sure that the addition (tmp + 10) only occurs after verifying that tmp is not SIZE_T_MAX, eliminates the risk of overflow. Legrandin#883
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making sure that the addition (tmp + 10) only occurs after verifying that tmp is not SIZE_T_MAX, eliminates the risk of overflow. #883