Skip to content

This addresses a problem caused by files in which a source element ha… #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LettError merged 2 commits into from
Mar 28, 2017
Merged

This addresses a problem caused by files in which a source element ha… #80

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e324222
This addresses a problem caused by files in which a source element ha…
LettError Mar 28, 2017
1a6e6d3
As per comment from @anthrotype use enumerate.
LettError Mar 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Lib/mutatorMath/ufo/document.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,12 +502,17 @@ def readSources(self):
</source>

"""
for sourceElement in self.root.findall(".sources/source"):
for sourceCount, sourceElement in enumerate(self.root.findall(".sources/source")):
# shall we just read the UFO here?
filename = sourceElement.attrib.get('filename')
# filename is a path relaive to the documentpath. resolve first.
sourcePath = os.path.abspath(os.path.join(os.path.dirname(self.path), filename))
sourceName = sourceElement.attrib.get('name')
if sourceName is None:
# if the source element has no name attribute
# (some authoring tools do not need them)
# then we should make a temporary one. We still need it for reference.
sourceName = "temp_master.%d"%(sourceCount)
self.reportProgress("prep", 'load', sourcePath)
if not os.path.exists(sourcePath):
raise MutatorError("Source not found at %s"%sourcePath)
Expand Down