Skip to content

types: add abstract-level type dependence#230

Closed
eng-cc wants to merge 1 commit into
Level:masterfrom
eng-cc:fix_type_deps
Closed

types: add abstract-level type dependence#230
eng-cc wants to merge 1 commit into
Level:masterfrom
eng-cc:fix_type_deps

Conversation

@eng-cc
Copy link
Copy Markdown

@eng-cc eng-cc commented Jan 31, 2023

add abstract-level type dependence

@vweevers
Copy link
Copy Markdown
Member

abstract-level is already present, as a transitive dependency.

@eng-cc
Copy link
Copy Markdown
Author

eng-cc commented Jan 31, 2023

abstract-level is already present, as a transitive dependency.

Transitive dependencies can sometimes be problematic.

In patterns that avoid using transitive dependencies, it needs to be explicitly defined.

such as pnpm

@vweevers
Copy link
Copy Markdown
Member

I see.

Perhaps we can instead re-export AbstractLevel from the classic-level and/or browser-level packages? What is the more common pattern in the TS ecosystem?

@eng-cc
Copy link
Copy Markdown
Author

eng-cc commented Jan 31, 2023

I see.

Perhaps we can instead re-export AbstractLevel from the classic-level and/or browser-level packages? What is the more common pattern in the TS ecosystem?

Re-export AbstractLevel from the classic-level or browser-level packages is also a nice solution.

But I think that re-export will lead to too many links of type export, which is not conducive to decoupling.

@vweevers
Copy link
Copy Markdown
Member

Fixed in #241 (added to dependencies instead of devDependencies).

@vweevers vweevers closed this Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants