Conversation
cd .. git clone https://git.busybox.net/buildroot cat buildroot/package/python3/*.patch > LibreELEC.tv/packages/lang/Python3/patches/Python3-0100-buildroot-patches.patch cd LibreELEC.tv s/build Python3:host git co -- packages/lang/Python3/patches/Python3-0100-buildroot-patches.patch
we have it enabled, do we need this or do we disable lib2to3 ?
do we need this ? it is 2022 and Centos7 does not matter for us
overall there are a lot stuff included that should be up streamed for ages :( |
I would prefer to take the patches we actually want / need. As it was a bit of a pain rebasing it as it was… but that being said either / or … Also should we leave it as a single build root patch, or separate into the [?] patches we actually want, and add a note/readme in the commit of which patches weren’t worthy of inclusion. |
|
Please split them, easier to maintain |
|
@CvH - Latest update. patches split apart. see my comments on the “rebased patches” as in that we use at least 7-8 of the 11.
|
|
Runtime testing on RPi4 looks good so far - I only use very few addons though |
|
Just a heads up, may want to keep an eye on this PR at cpython python/cpython#99268 It aims to fix what looks to be a pretty large memleak that will probably add up on devices that stay on (eg media centres) Memleak issue is python/cpython#99205 From kodi perspective, I'll probably patch our builds with this rather than wait for 3.11.1, but your timing is obviously different to Kodi release I've got scheduled |
|
@heitbaum please add python/cpython#99301 to the PR |
|
Thanks @fuzzard / @SupervisedThinking - added |
|
what about the lib2to3 patch ? so keep the patch and disable lib2to3 ? |
|
Done - I have set |
|
GTG? Still wip |
upstream patch: - GH-99205 - Should be included in Python 3.11.1
|
Squashed the commits. Dropped WIP Tag. |
First revision of patch to support:
the buildroot patches need to be reviewed.
Looking at the buildroot
changeshttps://git.busybox.net/buildroot/tree/CHANGES?id=aa8903447ca1c8da34b205d67cda4161723fd048 - not expecting buildroot Python to be updated to 3.11.x until at least after 22.11 is released in ? 4-6 weeks ?