Keep workflow learning aligned with table-permissions reality#15
Merged
Conversation
The prior workflow-issues learning assumed inline ACL payloads and legacy acl_apply staging, which now contradicts the current datasource workflow and frontend contract. This refresh replaces the stale learning with a successor doc reflecting workspace/datasource binding orchestration plus table-permissions governance, and adds AGENTS discoverability guidance for docs/solutions. Constraint: docs/solutions is ignored by default in this repo and required force-add for replacement doc Rejected: In-place update of the old learning | stale filename and ACL-framed narrative would keep drift risk high Confidence: high Scope-risk: narrow Reversibility: clean Directive: Treat /api/v1/datasources/workflow as context-binding orchestration; keep governance writes in table-permissions APIs Tested: Manual evidence verification against current DTO/service/tests and README contracts Not-tested: No lint/test suite run (docs and AGENTS changes only)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prior workflow-issues learning assumed inline ACL payloads and legacy acl_apply staging, which now contradicts the current datasource workflow and frontend contract. This refresh replaces the stale learning with a successor doc reflecting workspace/datasource binding orchestration plus table-permissions governance, and adds AGENTS discoverability guidance for docs/solutions.
Constraint: docs/solutions is ignored by default in this repo and required force-add for replacement doc
Rejected: In-place update of the old learning | stale filename and ACL-framed narrative would keep drift risk high
Confidence: high
Scope-risk: narrow
Reversibility: clean
Directive: Treat /api/v1/datasources/workflow as context-binding orchestration; keep governance writes in table-permissions APIs
Tested: Manual evidence verification against current DTO/service/tests and README contracts
Not-tested: No lint/test suite run (docs and AGENTS changes only)
Summary
Frontend Checklist
style={{...}})Validation
pnpm --filter @text2sql/frontend lintpnpm --filter @text2sql/frontend testpnpm --filter @text2sql/frontend buildPost-Deploy Monitoring & Validation