refactor: use random.choice over manual index arithmetic in name generation#56
Open
deependujha wants to merge 3 commits into
Open
Conversation
deependujha
requested review from
ethanwharris,
justusschock,
owbone and
tchaton
as code owners
owbone
previously approved these changes
May 26, 2026
owbone
reviewed
May 26, 2026
Collaborator
owbone
left a comment
owbone
left a comment
There was a problem hiding this comment.
Change looks good but looks like there's a legit test failure:
E AssertionError: assert 'deaf-amber-mmhf' == 'deaf-amber-vrpo'
E
E - deaf-amber-vrpo
E + deaf-amber-mmhf
Author
|
thanks @owbone. fixed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.