Fix cross-platform test runner#25
Open
Yulin-Bi wants to merge 1 commit intoLiuMengxuan04:mainfrom
Open
Conversation
Owner
|
抱歉,我没看懂这个pr做了什么?可否请你更详细的解释一下本次修改的具体行为?(最好可以参考本项目的pr规范) |
Author
提交说明 / Submission Note1、背景 / Background项目原有测试脚本使用 "test": "node --import tsx --test test/*.test.ts"该写法依赖 shell 对 glob 的展开能力。在 Windows PowerShell 环境下, 这会导致 Windows 用户无法直接通过 2、目标 / Goal修复 同时保持测试入口简单、稳定,并兼容不同操作系统和 shell 环境,使开发者可以在 Windows、macOS、Linux 上使用同一条命令运行测试: npm test3、修改方向 / Direction将 "test": "node test/run-tests.mjs"新增
这种方式不依赖 shell glob 展开,因此可以解决 Windows PowerShell 下测试命令失效的问题。 4、验收标准 / Acceptance Criteria本次修改满足以下验收标准:
npm run check
npm test当前验证结果: |
Collaborator
|
感谢提交这个 PR!我们之前的开发环境一直聚焦在 Linux,确实疏忽了 Windows 下的兼容性问题。感谢你的补全,我会立即联络项目负责人,尽快安排 review 并在完成后合入。 |
Author
|
这个项目对我学习帮助很大,这是我应该做的,希望越来越好! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
windows可以快速测试。