Add *DB.SetOptions()#5
Merged
Rupert Chen (rupertchen) merged 2 commits intoFeb 21, 2019
Merged
Conversation
Rupert Chen (rupertchen)
force-pushed
the
draft/set-options
branch
from
February 20, 2019 18:44
39ff805 to
abff5cc
Compare
Rupert Chen (rupertchen)
requested a review
from Johnny Graettinger (jgraettinger)
February 20, 2019 18:48
Johnny Graettinger (jgraettinger)
approved these changes
Feb 21, 2019
Johnny Graettinger (jgraettinger)
left a comment
Johnny Graettinger (jgraettinger)
left a comment
There was a problem hiding this comment.
:lgtm: % nit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change has the same diff as tecbot#155 but made against our fork. Once the upstream PR is accepted, we can rebase our fork against master skipping this change.
Connects LiveRamp/gazette#112