Skip to content

versioning: fix dirty commit notifications #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReenigneArcher merged 1 commit into from
Mar 27, 2023
Merged

versioning: fix dirty commit notifications #1084

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions src_assets/common/assets/web/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ <h1 class="my-4">Hello, Sunshine!</h1>
<div class="card-body" v-if="version">
<h2>Version {{version}}</h2>
<br />
<div class="alert alert-success" v-if="version.indexOf('dirty') !== -1">
Thank you for helping to make Sunshine a better software! 🌇
</div>
<div v-if="loading">
Loading Latest Release...
</div>
<div v-else-if="!nightlyBuildAvailable && !stableBuildAvailable">
<div class="alert alert-success" v-if="runningDirtyBuild">
Thank you for helping to make Sunshine a better software! 🌇
</div>
<div v-else-if="!nightlyBuildAvailable && !stableBuildAvailable && !runningDirtyBuild">
<div class="alert alert-success">
You're running the latest version of Sunshine
</div>
Expand Down Expand Up @@ -97,18 +97,19 @@ <h2>Legal</h2>
this.loading = false;
},
computed: {
runningDirtyBuild() {
return this.buildVersionIsDirty()
},
stableBuildAvailable() {
// If we can't get versions, return false
if (!this.githubVersion || !this.version) return false;
// If built with dirty git tree, return false
if (this.version.indexOf("dirty") !== -1) return false;
// Get the GitHub version tag
let v = this.githubVersion.name;
// If the version starts with a v, remove it
if (v.indexOf("v") === 0) v = v.substring(1);

// if nightly, we do an additional check to make sure its an actual upgrade.
if (this.buildVersionIsNightly()) {
// if nightly or dirty, we do an additional check to make sure it's an actual upgrade.
if (this.buildVersionIsNightly() || this.buildVersionIsDirty()) {
const stableVersion = this.version.split('.').slice(0, 3).join('.');
return this.githubVersion.tag_name.substring(1) > stableVersion;
}
Expand All @@ -121,19 +122,23 @@ <h2>Legal</h2>
// This is important to ensure the UI does not try to load undefined values.
if (!this.nightlyData || this.buildVersionIsStable()) return false;
// If built with dirty git tree, return false
if (this.version?.indexOf("dirty") !== -1) return false;
if (this.buildVersionIsDirty()) return false;
// Get the commit hash
let commit = this.version?.split(".").pop();
// return true if the commit hash is different, otherwise false
return this.nightlyData.head_sha.indexOf(commit) !== 0;
}
},
methods: {
buildVersionIsStable() {
return this.version?.split(".").length === 3;
buildVersionIsDirty() {
return this.version?.split(".").length === 5 &&
this.version.indexOf("dirty") !== -1
},
buildVersionIsNightly() {
return this.version?.split(".").length === 4
},
buildVersionIsStable() {
return this.version?.split(".").length === 3
}
}
});
Expand Down