Skip to content

ci(docker): move app-image to docker - #1563

Closed
ReenigneArcher wants to merge 1 commit into
nightlyfrom
ci(docker)-move-app-image-to-docker
Closed

ci(docker): move app-image to docker#1563
ReenigneArcher wants to merge 1 commit into
nightlyfrom
ci(docker)-move-app-image-to-docker

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

This PR moves the AppImage build to Docker. The tools to package the AppImage are not available for aarch64, so it will not do anything extra for that architecture.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@LizardByte-bot

LizardByte-bot commented Aug 23, 2023

Copy link
Copy Markdown
Member

Qodana success
Results:
- python
- js

@github-actions

github-actions Bot commented Aug 23, 2023

Copy link
Copy Markdown

Qodana for JS

It seems all right 👌

No new problems were found according to the checks applied

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.2.1
        with:
          upload-result: true
Dependencies licenses

Third-party software list

This page lists the third-party software dependencies used in project

Dependency Version Licenses
@fortawesome/fontawesome-free 6.4.0 OFL-1.1-no-RFN
@popperjs/core 2.11.8 MIT
bootstrap 5.3.0 MIT
vue 2.6.12 MIT
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@github-actions

github-actions Bot commented Aug 23, 2023

Copy link
Copy Markdown

Qodana for Python

It seems all right 👌

No new problems were found according to the checks applied

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.2.1
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@ReenigneArcher
ReenigneArcher force-pushed the ci(docker)-move-app-image-to-docker branch from 4bc24b8 to 43932a4 Compare August 23, 2023 13:07
@ReenigneArcher

ReenigneArcher commented Aug 23, 2023

Copy link
Copy Markdown
Member Author

Apparently I already tried, this and decided against it for the reasons listed in this PR #714

So closing again.

@ReenigneArcher
ReenigneArcher deleted the ci(docker)-move-app-image-to-docker branch August 23, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants