Skip to content

fix(rtsp): fix RTSP timeout after quitting an app #3376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cgutman merged 2 commits into from
Nov 7, 2024
Merged

fix(rtsp): fix RTSP timeout after quitting an app #3376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e43c53
fix(rtsp): fix RTSP timeout after quitting an app
cgutman Nov 7, 2024
c6f7bab
fix(process): ignore failures when terminating the process group
cgutman Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/process.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@ namespace proc {

// We always call terminate() even if we waited successfully for all processes above.
// This ensures the process group state is consistent with the OS in boost.
group.terminate();
std::error_code ec;
group.terminate(ec);
group.detach();
}

Expand Down
4 changes: 0 additions & 4 deletions src/rtsp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,10 +588,6 @@ namespace rtsp_stream {
i++;
}
}

if (all && !ios.stopped()) {
ios.stop();
}
}

/**
Expand Down