feat(web-ui): replace dropdown menus with checkboxes - #3455
Merged
ReenigneArcher merged 3 commits intoJan 5, 2025
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3455 +/- ##
========================================
Coverage 7.87% 7.87%
========================================
Files 90 90
Lines 15803 15803
Branches 7487 7487
========================================
Hits 1244 1244
- Misses 12133 14080 +1947
+ Partials 2426 479 -1947
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
FrogTheFrog
force-pushed
the
checkbox-replacement
branch
from
December 16, 2024 21:37
4bd8cd2 to
59913ab
Compare
FrogTheFrog
marked this pull request as ready for review
December 16, 2024 21:39
FrogTheFrog
force-pushed
the
checkbox-replacement
branch
from
December 16, 2024 22:14
59913ab to
74c99f3
Compare
ReenigneArcher
requested changes
Dec 17, 2024
ReenigneArcher
left a comment
ReenigneArcher
left a comment
Member
There was a problem hiding this comment.
I still need to review the input accordion a little closer.
FrogTheFrog
force-pushed
the
checkbox-replacement
branch
2 times, most recently
from
December 23, 2024 11:27
0274081 to
60d7c1c
Compare
2 tasks
ReenigneArcher
left a comment
ReenigneArcher
left a comment
Member
There was a problem hiding this comment.
Sorry for the delay, I didn't want to disturb you over the holidays.
FrogTheFrog
force-pushed
the
checkbox-replacement
branch
from
January 4, 2025 10:53
60d7c1c to
13744d3
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Copilot reviewed 5 out of 14 changed files in this pull request and generated no comments.
Files not reviewed (9)
- src_assets/common/assets/web/apps.html: Language not supported
- src_assets/common/assets/web/public/assets/locale/en.json: Language not supported
- src_assets/common/assets/web/Checkbox.vue: Evaluated as low risk
- src_assets/common/assets/web/configs/tabs/AudioVideo.vue: Evaluated as low risk
- src_assets/common/assets/web/configs/tabs/General.vue: Evaluated as low risk
- src_assets/common/assets/web/configs/tabs/Inputs.vue: Evaluated as low risk
- src_assets/common/assets/web/configs/tabs/Network.vue: Evaluated as low risk
- src_assets/common/assets/web/configs/tabs/audiovideo/AdapterNameSelector.vue: Evaluated as low risk
- src_assets/common/assets/web/configs/tabs/audiovideo/DisplayModesSettings.vue: Evaluated as low risk
ReenigneArcher
force-pushed
the
checkbox-replacement
branch
from
January 5, 2025 19:18
0b509c0 to
3de0084
Compare
|
ReenigneArcher
approved these changes
Jan 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaced the enabled/disabled dropdowns with checkboxes.
Except this one as it has custom dropdown values and it seems that it could possible have more values in the future:
Additionally fixed incorrectly labeled default values, some missing/mis-configured translation stuff and styling issues.
Screenshots
General
Before
After
Input
Before 1
After 1
Before 2
After 2
Before 3
After 3
Before 4
After 4
Audio/Video
Before
After
Network
Before
After
Nvidia
Before
After
Intel
Before
After
AMD
Before
After
VideoToolbox
Before
After
VA-API
Before
After
Apps
Before
After
Type of Change
.github/...)Checklist