refactor(confighttp): HTML page handlers into generic getPage function

[ReenigneArcher]

Description

Initial motivation for the PR was to consolidate multiple individual HTML page handler functions into a single getPage function. This works by providing the page as a parameter. Then HTTP handler functions were updated to take response and request by const reference, which was a clang-tidy suggestion. New helper functions for page handlers were added to simplify the server route setup.

Introduced check_request_body_empty to validate that certain API endpoints receive no request body, replacing previous content-type checks where appropriate. I am not 100% sure if this is necessary. Docs were updated to only include the Content-Type headers when necessary.

Also, added some initial tests for confighttp.cpp/h.

Lastly, I had to add macros to ignore some error/warnings in tests/tests_common.h due to failures in the ArchLinux build. I am not fully understanding what caused these errors to start occurring.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

• feat: New feature (non-breaking change which adds functionality)
• fix: Bug fix (non-breaking change which fixes an issue)
• docs: Documentation only changes
• style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
• refactor: Code change that neither fixes a bug nor adds a feature
• perf: Code change that improves performance
• test: Adding missing tests or correcting existing tests
• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Other changes that don't modify src or test files
• revert: Reverts a previous commit
• BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

• Code follows the style guidelines of this project
• Code has been self-reviewed
• Code has been commented, particularly in hard-to-understand areas
• Code docstring/documentation-blocks for new or existing methods/components have been added or updated
• Unit tests have been added or updated for any new or modified functionality

AI Usage

• None: No AI tools were used in creating this PR
• Light: AI provided minor assistance (formatting, simple suggestions)
• Moderate: AI helped with code generation or debugging specific parts
• Heavy: AI generated most or all of the code changes

[codecov]

Bundle Report

Changes will increase total bundle size by 853 bytes (0.11%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
sunshine-esm	774.17kB	853 bytes (0.11%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sunshine-esm

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
assets/_plugin-*.js	307 bytes	350.97kB	0.09%
assets/_plugin-*.css	113 bytes	231.27kB	0.05%
assets/config-*.js	433 bytes	67.43kB	0.65%

[codecov]

Codecov Report

❌ Patch coverage is 26.18026% with 172 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.52%. Comparing base (3fbbe88) to head (e8d59ee).
⚠️ Report is 223 commits behind head on master.

Files with missing lines	Patch %	Lines
src/confighttp.cpp	29.75%	72 Missing and 72 partials ⚠️
src/config.cpp	0.00%	18 Missing and 10 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4645      +/-   ##
==========================================
+ Coverage   16.74%   17.52%   +0.78%     
==========================================
  Files         106      106              
  Lines       21762    21813      +51     
  Branches     9737     9770      +33     
==========================================
+ Hits         3644     3823     +179     
+ Misses      13397    13257     -140     
- Partials     4721     4733      +12     

Flag	Coverage Δ
Archlinux	12.05% <19.61%> (+0.99%)	⬆️
FreeBSD-14.3-aarch64	?
FreeBSD-14.3-amd64	13.86% <17.85%> (+0.81%)	⬆️
Homebrew-ubuntu-22.04	14.36% <23.92%> (+1.10%)	⬆️
Linux-AppImage	12.54% <23.92%> (+1.07%)	⬆️
Windows-AMD64	14.49% <22.00%> (+1.06%)	⬆️
Windows-ARM64	13.11% <17.48%> (+0.76%)	⬆️
macOS-arm64	18.22% <21.07%> (+1.25%)	⬆️
macOS-x86_64	16.71% <20.30%> (+1.17%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/config.h	0.00% <ø> (ø)
src/config.cpp	3.18% <0.00%> (+0.01%)	⬆️
src/confighttp.cpp	19.97% <29.75%> (+18.25%)	⬆️

... and 20 files with indirect coverage changes

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[psyke83]

I think this commit has broken the webui? Clicking "save" has no response on my local builds, but reverting this fixes it. Maybe it's because I'm running through a reverse proxy?

[ReenigneArcher]

@psyke83 I should have updated the commit title before I merged it. It also adds CSRF protection. You can add your trusted domains to the csrf_allowed_origins option. It's on the network tab of the UI. You would have to do this from localhost or manually edit the config file.

[psyke83]

Ah, I only read the PR description before commenting - sorry. It works correctly over reverse proxy when I set the trusted domain.