Video: revert software bitrate change & use more conservative bufsize - #482
Merged
Conversation
psyke83
force-pushed
the
change_bufsize
branch
from
November 7, 2022 01:51
ca3c9f8 to
cae5ace
Compare
psyke83
changed the title
2 tasks
psyke83
force-pushed
the
change_bufsize
branch
from
November 8, 2022 02:07
cae5ace to
4cdcd63
Compare
psyke83
marked this pull request as ready for review
November 9, 2022 00:47
psyke83
force-pushed
the
change_bufsize
branch
from
November 17, 2022 00:39
4cdcd63 to
c0b5961
Compare
…lculation" This reverts commit 1b6bf8f.
…4 slice count If the libx264 encoder is configured to use >4 slices, the existing bufsize (bitrate / framerate) is set too low, causing a quality degradation and failure for the encoder to attain the target bitrate. A previous commit set this to a larger value (bitrate / 10), but this seemed to cause issues with the RPI3 hardware decoder; see: LizardByte#478 Ref: https://trac.ffmpeg.org/wiki/Limiting%20the%20output%20bitrate "Specifying too small -bufsize would cause ffmpeg to degrade the output image quality, because it would have to (frequently) conform to the limitations and would not have enough of a free space to use some optimizations (for example, optimizations based on the frame repetitions and similar), because the buffer would not contain enough frames for the optimizations to be effective."
ReenigneArcher
force-pushed
the
change_bufsize
branch
from
December 15, 2022 16:32
c0b5961 to
9cb47a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issues Fixed or Closed
Closes #478
Type of Change
Checklist