fix(packaging/windows): Allow WiX installer downgrades - #5435
Merged
Conversation
Bundle ReportBundle size has no change ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5435 +/- ##
==========================================
+ Coverage 26.68% 26.85% +0.16%
==========================================
Files 111 111
Lines 25397 25397
Branches 11231 11231
==========================================
+ Hits 6777 6820 +43
- Misses 15597 17208 +1611
+ Partials 3023 1369 -1654
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
|
Update Windows WiX packaging to better support users switching between release and PR builds. This adds `CPACK_WIX_PROPERTY_REINSTALLMODE` (`amus`) so files are replaced regardless of embedded file version, and introduces a custom WiX template with `<MajorUpgrade AllowDowngrades="yes">` instead of CPack's default downgrade-blocking behavior.
ReenigneArcher
force-pushed
the
fix/packaging/wix-upgrade-detection
branch
from
July 21, 2026 21:37
91a871d to
52a7086
Compare
|
ReenigneArcher
marked this pull request as ready for review
July 21, 2026 22:28
This was referenced Jul 21, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a custom WiX template that sets AllowDowngrades="yes" on the MajorUpgrade element. This lets users freely switch between release and PR builds without being blocked by the default downgrade prevention.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.