fix(linux/kms): use same methodology for display name matching and list generation - #5448
Conversation
|
This should at least help with debugging #5444 but I think it's unlikely a fix by itself (unless something I'm not expecting is going on). |
6f5d0a7 to
4046739
Compare
|
Bundle ReportBundle size has no change ✅ |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5448 +/- ##
=========================================
Coverage ? 26.89%
=========================================
Files ? 111
Lines ? 25410
Branches ? 11236
=========================================
Hits ? 6835
Misses ? 16522
Partials ? 2053
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
|
Do you want to have them test this PR before merging? |
|
No, this can be merged as it will ensure things work correctly. For #5444 it'll just help debugging if it fixes that issue by accident then i'd call that a nice by-product. |
Port upstream LizardByte#5423/LizardByte#5448 so Linux lists DP-1/HDMI-A-1 style names while still accepting legacy numeric output_name values.
Port upstream LizardByte#5423/LizardByte#5448 so Linux lists DP-1/HDMI-A-1 style names while still accepting legacy numeric output_name values.



Description
This is a small addendum to #5423 to ensure there is never a mismatch between the KMS display list generation and display matching code by changing the latter to use the same methodology for matching to kmsgrab monitor index.
Both cases now generate a string using
std::format("{}-{}", drmModeGetConnectorTypeName(type), index)and either add it to the display_name list or check if it string matches the value given during kmsgrab display init.Also adds a log of the final display_names list returned to simplify debugging available display_names.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.