Skip to content

fix: handle exceptions explicitly in destructors - #251

Merged
ReenigneArcher merged 2 commits into
masterfrom
refactor/sonar-fixes
Jun 9, 2026
Merged

fix: handle exceptions explicitly in destructors#251
ReenigneArcher merged 2 commits into
masterfrom
refactor/sonar-fixes

Handle exceptions explicitly in destructors

f06644c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 9, 2026 in 0s

92.87% (-0.14%) compared to 459e545

View this Pull Request on Codecov

92.87% (-0.14%) compared to 459e545

Details

Codecov Report

❌ Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.87%. Comparing base (459e545) to head (f06644c).

Files with missing lines Patch % Lines
src/common/logging.cpp 77.77% 0 Missing and 2 partials ⚠️
src/common/retry_scheduler.cpp 77.77% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #251      +/-   ##
==========================================
- Coverage   93.01%   92.87%   -0.14%     
==========================================
  Files          35       35              
  Lines        2275     2289      +14     
  Branches     1120     1126       +6     
==========================================
+ Hits         2116     2126      +10     
- Misses         42       60      +18     
+ Partials      117      103      -14     
Files with missing lines Coverage Δ
src/common/include/display_device/logging.h 100.00% <ø> (ø)
...rc/common/include/display_device/retry_scheduler.h 97.36% <ø> (ø)
src/common/logging.cpp 93.24% <77.77%> (-2.28%) ⬇️
src/common/retry_scheduler.cpp 90.00% <77.77%> (-10.00%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 459e545...f06644c. Read the comment docs.