refactor(sonar): fix cpp:S112

[ReenigneArcher]

Description

Fix sonar cpp:S112

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

• feat: New feature (non-breaking change which adds functionality)
• fix: Bug fix (non-breaking change which fixes an issue)
• docs: Documentation only changes
• style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
• refactor: Code change that neither fixes a bug nor adds a feature
• perf: Code change that improves performance
• test: Adding missing tests or correcting existing tests
• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Other changes that don't modify src or test files
• revert: Reverts a previous commit
• BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

• Code follows the style guidelines of this project
• Code has been self-reviewed
• Code has been commented, particularly in hard-to-understand areas
• Code docstring/documentation-blocks for new or existing methods/components have been added or updated
• Unit tests have been added or updated for any new or modified functionality

AI Usage

• None: No AI tools were used in creating this PR
• Light: AI provided minor assistance (formatting, simple suggestions)
• Moderate: AI helped with code generation or debugging specific parts
• Heavy: AI generated most or all of the code changes

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.16%. Comparing base (0f91197) to head (e2eee28).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #260   +/-   ##
=======================================
  Coverage   93.16%   93.16%           
=======================================
  Files          35       35           
  Lines        2268     2268           
  Branches     1107     1107           
=======================================
  Hits         2113     2113           
- Misses         42       49    +7     
+ Partials      113      106    -7     

Flag	Coverage Δ
Linux	93.84% <100.00%> (ø)
Windows-AMD64	91.83% <100.00%> (ø)
Windows-ARM64	65.24% <8.33%> (ø)
macOS	74.00% <12.50%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/common/file_settings_persistence.cpp	58.13% <100.00%> (ø)
...de/display_device/detail/json_serializer_details.h	100.00% <100.00%> (ø)
...rc/common/include/display_device/retry_scheduler.h	97.36% <100.00%> (ø)
src/windows/persistent_state.cpp	97.72% <100.00%> (ø)
src/windows/settings_manager_general.cpp	100.00% <100.00%> (ø)
src/windows/win_display_device_general.cpp	100.00% <100.00%> (ø)

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f91197...e2eee28. Read the comment docs.