Skip to content

fix(virtualhid_control): improve compact layout #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReenigneArcher merged 1 commit into from
Aug 8, 2026
Merged

fix(virtualhid_control): improve compact layout #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/usage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ normalized gamepad output such as rumble, RGB LED, adaptive trigger, trigger
rumble, and raw report events delivered through the normal callback path. Button
controls are momentary by default so they behave like physical gamepad buttons;
enable `Lock buttons` to keep the old click-to-toggle behavior for held inputs.
The resizable window supports a compact width. Its device and control panels
stack, and the button grid reflows, to keep controls usable when it is narrowed.
The UI intentionally does not use gamepad navigation so virtual devices created
by the tool cannot drive the tool's own controls.

Expand Down
17 changes: 11 additions & 6 deletions tools/virtualhid_control.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,11 +271,15 @@ namespace {
ImGui::Begin("libvirtualhid control", nullptr, window_flags);

const auto backend = backend_text(*runtime_);
ImGui::TextUnformatted(backend.c_str());
ImGui::TextWrapped("%s", backend.c_str());
ImGui::Separator();

if (ImGui::BeginTable("control-layout", 2, ImGuiTableFlags_Resizable | ImGuiTableFlags_BordersInnerV)) {
ImGui::TableSetupColumn("Devices", ImGuiTableColumnFlags_WidthFixed, 330.0F);
if (ImGui::GetContentRegionAvail().x < 760.0F) {
render_device_panel(devices);
ImGui::Separator();
render_control_panel(selected);
} else if (ImGui::BeginTable("control-layout", 2, ImGuiTableFlags_Resizable | ImGuiTableFlags_BordersInnerV)) {
ImGui::TableSetupColumn("Devices", ImGuiTableColumnFlags_WidthFixed, 220.0F);
ImGui::TableSetupColumn("Controls", ImGuiTableColumnFlags_WidthStretch);
ImGui::TableNextRow();

Expand Down Expand Up @@ -459,7 +463,8 @@ namespace {
button_active_.fill(false);
}

if (ImGui::BeginTable("buttons", 4, ImGuiTableFlags_SizingStretchSame)) {
const auto column_count = ImGui::GetContentRegionAvail().x < 480.0F ? 3 : 4;
if (ImGui::BeginTable("buttons", column_count, ImGuiTableFlags_SizingStretchSame)) {
for (std::size_t index = 0; index < button_choices.size(); ++index) {
if (!visible_buttons[index]) {
continue;
Expand Down Expand Up @@ -955,9 +960,9 @@ namespace {
main_scale = 1.0F;
}

constexpr auto base_width = 1120;
constexpr auto base_width = 860;
constexpr auto base_height = 760;
constexpr auto minimum_width = 980;
constexpr auto minimum_width = 600;
constexpr auto minimum_height = 700;
const auto window_flags = SDL_WINDOW_RESIZABLE | SDL_WINDOW_HIDDEN | SDL_WINDOW_HIGH_PIXEL_DENSITY;
auto *window = SDL_CreateWindow(
Expand Down
Loading