Skip to content

Upd: Asset GET_SHIP - #3560

Closed
guoh064 wants to merge 1 commit into
LmeSzinc:devfrom
guoh064:get_ship
Closed

Upd: Asset GET_SHIP#3560
guoh064 wants to merge 1 commit into
LmeSzinc:devfrom
guoh064:get_ship

Conversation

@guoh064

@guoh064 guoh064 commented Mar 18, 2024

Copy link
Copy Markdown
Collaborator

close #3091

ezgif-5-7e7838446a

@LmeSzinc

LmeSzinc commented Mar 20, 2024 •
edited
Loading

Copy link
Copy Markdown
Owner

历史遗留不建议在未经广泛测试的情况下轻易改动，调用GET_SHIP的地方，那可不是一般地多

  1. 即使更改也建议选择纯白色 (255, 255, 255) 的区域
  2. 可以尝试将 combat_status 中的 handle_get_ship() 移动到 handle_exp_info() 后
  3. GET_SHIP 的点击间隔是1s，就算误判了那么在1s内也应该有第二张截图触发 handle_exp_info()，除非截图耗时超过了1s，所以这算 slow PC issue

@LmeSzinc LmeSzinc added the slow PC issue / 电脑太慢 Running on a Low-End PC, too slow to take a screen shot label Mar 20, 2024
@guoh064

guoh064 commented Mar 25, 2024

Copy link
Copy Markdown
Collaborator Author

看起来解决了，出现这个问题是因为我自己重构handle_get_ship()的时候没有给appear(GET_SHIP)加interval。

我这几天再测试一下。没问题我就关了问题和pr吧

@guoh064 guoh064 closed this Mar 27, 2024
@guoh064
guoh064 deleted the get_ship branch April 4, 2024 14:56
@guoh064
guoh064 restored the get_ship branch April 4, 2024 14:56
@guoh064
guoh064 deleted the get_ship branch April 23, 2024 03:04
@Air111 Air111 mentioned this pull request May 22, 2024
Closed
@zuak110 zuak110 mentioned this pull request May 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

slow PC issue / 电脑太慢 Running on a Low-End PC, too slow to take a screen shot

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@guoh064 @LmeSzinc