-
Notifications
You must be signed in to change notification settings - Fork 50
290 desktop client should not force user to setup a local core #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jhuang38
wants to merge
6
commits into
dev
Choose a base branch
from
290-desktop-client-should-not-force-user-to-setup-a-local-core
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
dc076e9
added button to allow user to connect to existing
jhuang38 bb5a12b
added adhoc impl for local setup in core select
jhuang38 048214c
hard-coded local tauri setup changes
jhuang38 9fc390a
generalized core select logic
jhuang38 02a087a
Update dashboard/src/pages/login/CoreSelectExisting.tsx
jhuang38 bb7aad3
login flow back support
jhuang38 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,10 +15,13 @@ const FirstTime = () => { | |
| const [tauriIsSetup, setTauriIsSetup] = useState(false); | ||
|
|
||
| useEffectOnce(() => { | ||
| if (coreList.length > 0) { | ||
| setPathname('/login/core/select'); | ||
| return; | ||
| } | ||
|
|
||
| // if (coreList.length > 0) { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why is this redirect commented out? |
||
| // console.log({coreList}) | ||
| // setPathname('/login/core/select'); | ||
| // console.log("redirecting to /login/core/select") | ||
| // return; | ||
| // } | ||
| if (!tauri) return; | ||
| tauri | ||
| .invoke<string | null>('is_setup') | ||
|
|
@@ -27,7 +30,7 @@ const FirstTime = () => { | |
| setCore(DEFAULT_LOCAL_CORE); | ||
| setTauriIsSetup(is_setup === 'true'); | ||
| }) | ||
| .catch((err: any) => { | ||
| .catch((err: Error) => { | ||
| console.error('Tauri call failed is_setup', err); | ||
| }); | ||
| }); | ||
|
|
@@ -95,7 +98,7 @@ const FirstTime = () => { | |
| <Button | ||
| label="Connect to existing Core" | ||
| onClick={() => setPathname('/login/core/new')} | ||
| intention="primary" | ||
| intention="info" | ||
| size="large" | ||
| className="whitespace-nowrap" | ||
| /> | ||
|
|
@@ -109,13 +112,26 @@ const FirstTime = () => { | |
| className="whitespace-nowrap" | ||
| /> | ||
| ) : ( | ||
| <Button | ||
| label="Setup Lodestone Core" | ||
| onClick={() => setPathname('/login/core/first_setup')} | ||
| intention="primary" | ||
| size="large" | ||
| className="whitespace-nowrap" | ||
| /> | ||
| <> | ||
| <Button | ||
| label="Use local core" | ||
| onClick={() => setPathname('/login/core/first_setup')} | ||
| intention="primary" | ||
| size="large" | ||
| className="whitespace-nowrap" | ||
| /> | ||
| <Button | ||
| label="Connect to existing core" | ||
| onClick = {() => { | ||
| setPathname('/login/core/select') | ||
| }} | ||
| intention = 'primary' | ||
| size = "large" | ||
| className="whitespace-nowrap" | ||
| /> | ||
|
|
||
| </> | ||
|
|
||
| )} | ||
| </div> | ||
| </div> | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be shortened to onClick={navigateBack}?