Open
Conversation
✅ Deploy Preview for lodestone-dashboard canceled.
|
✅ Deploy Preview for lodestone-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Author
|
An alternative would be #422, but I considered this a less obtrusive change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current docker image does not support any path routing. If you go to any
path other than the root, it 404s.
For example, if you go to a page other than the index and then refresh, it will
404.
This adds basic routing to fall back to
index.htmlif a file isn't found. Thisis already properly handled by the built
index.htmlsuch that an invalid pathwill show a proper 404 page (rather than the nginx 404 page).
Type of change
Note: make sure your files are formatted with rust-analyzer