Skip to content

AB#38716 MSAL integration with DevXApi application/RSC endpoint#11

Merged
gracet9182 merged 13 commits into
interns/feature/ge-app-mode-proxy-endpointfrom
interns/gracet9182/38715-output-app-token
Jul 22, 2021
Merged

AB#38716 MSAL integration with DevXApi application/RSC endpoint#11
gracet9182 merged 13 commits into
interns/feature/ge-app-mode-proxy-endpointfrom
interns/gracet9182/38715-output-app-token

Conversation

@gracet9182

@gracet9182 gracet9182 commented Jul 16, 2021

Copy link
Copy Markdown
Member

Overview

Notes

Depending on your configuration, you may need to set up an Azure blob. I've recorded a video how to set it up for devxapi. This is done via Azure Portal. Sign in into your microsoft.com email to get access to the Garage azure. You will need to use the connection string from the azure storage and put it in appsettings.json

Azure.Blob.mp4

Demo

  • I ran this locally and then hit the endpoint at /graphproxy/token/{tenantId} (note it was /graphproxy/token but is now /graphproxy/token/{tenantId}
  • Then, I tested that the token was able to use the RSC permission by deleting a channel
  • Prerequisite: Have the app installed in the teams that you are about to delete
Testing.token.mp4

Testing Instructions

  • Pull this branch
  • Fill in the TenantId, ClientId, ClientSecret and AzureConnectionString (refer to Notes in this PR) inside appsettings.json
  • Open in Visual Studio
  • Run in IIS Express
  • GET https://localhost:44399/graphproxy/token/{tenantId} in postman

@omersayshi omersayshi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check my comments out below

Comment thread GraphWebApi/Controllers/GraphExplorerAppModeController.cs Outdated
Comment thread GraphWebApi/Controllers/GraphExplorerAppModeController.cs Outdated
@gracet9182 gracet9182 changed the title AB#38715 MSAL integration with DevXApi application/RSC endpoint AB#38716 MSAL integration with DevXApi application/RSC endpoint Jul 20, 2021
@gracet9182
gracet9182 requested a review from omersayshi July 20, 2021 19:34
@gracet9182
gracet9182 force-pushed the interns/gracet9182/38715-output-app-token branch from 6f94d43 to c805d76 Compare July 21, 2021 17:19
@gracet9182
gracet9182 changed the base branch from interns/omersayshi/38714-app-mode-endpoint to interns/feature/ge-app-mode-proxy-endpoint July 21, 2021 17:21

@omersayshi omersayshi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Great work!

@jerryxihe

Copy link
Copy Markdown
Collaborator

Tested this with the Teams app (as well as Postman) and everything seemed good once CORS was disabled. Great work!

@gracet9182
gracet9182 merged commit fddc837 into interns/feature/ge-app-mode-proxy-endpoint Jul 22, 2021
@gracet9182
gracet9182 deleted the interns/gracet9182/38715-output-app-token branch August 12, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants