Skip to content

AB#39171 Added teamsAppSampleQueries in model and extended ordering functionality - #13

Merged
omersayshi merged 4 commits into
interns/devfrom
interns/omersayshi/39171-app-mode-sample-queries
Jul 27, 2021
Merged

AB#39171 Added teamsAppSampleQueries in model and extended ordering functionality#13
omersayshi merged 4 commits into
interns/devfrom
interns/omersayshi/39171-app-mode-sample-queries

Conversation

@omersayshi

@omersayshi omersayshi commented Jul 20, 2021

Copy link
Copy Markdown

Overview

Currently the samples endpoint orders the sample queries when returned and this causes new entries to not be returned. This PR fixes that problem by adding teamsAppSampleQueries to the model and the filtering

Testing Instructions

  • Get the repo and the branch running
  • Call the endpoint /samples?org=LokiLabs&branchName=ADD_YOUR_BRANCH_NAME_HERE
  • Scroll all the way down to the returned samples and you will find the list teamsAppSampleQueries

NOTE: ADD_YOUR_BRANCH_NAME_HERE should be a branch based on the devx_content repo, if you dont have a branch or didnt create one. You can use '38584-app-sample-queries'.

ADO: https://dev.azure.com/microsoftgarage/Intern%20GitHub/_sprints/taskboard/GI21%20-%20Graph%20Explorer/Intern%20GitHub/Y21-S/07?workitem=39171

Added teamsAppSampleQueries in model and extended ordering functionality

@lhao03 lhao03 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@omersayshi
omersayshi merged commit 9474f45 into interns/dev Jul 27, 2021
@omersayshi
omersayshi deleted the interns/omersayshi/39171-app-mode-sample-queries branch July 27, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants