Refactor Common Models into a more consistent paradigm with more clearly defined semantics.#752
Closed
bharat wants to merge 1 commit into
Closed
Refactor Common Models into a more consistent paradigm with more clearly defined semantics.#752bharat wants to merge 1 commit into
bharat wants to merge 1 commit into
Conversation
…rly defined semantics. 1. Contexts - one way data from Loop to the Status & Watch extensions 2. Settings - internal only models used to store Loop settings 3. Types - largely internal enums 4. UserInfos - dictionaries passed back from the watch to Loop
loopkitdev
pushed a commit
to loopkitdev/Loop
that referenced
this pull request
Mar 12, 2026
* Preset editing * Preset editing updates * Add duration editing * Add duration for legacy workout override
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor Common Models into a more consistent paradigm with more clearly defined semantics.
This is an attempt to normalize our models, which have suffered from some ad hoc creep. I broke it up into 4 categories and tried to get most things to fit into them. I haven't done this across the board for all Models, wanted to start here and get a sense for whether or not this is worth pursuing.
Here's what the final result looks like, to give you some idea of the structure:
