Improve the visibility of the options to select#549
Merged
Conversation
Contributor
|
May I suggest to either
The blue color ( |
Contributor
Author
|
In the Issue, @ps2 requested "stick to existing iOS conventions for color". I was not quite sure how to do that:
I captured a bunch of other screen shots, but I think these are sufficient. Original and current commit Dark Original and current commit Light |
Contributor
|
I'm not qualified to say anything on color schemes, but the current commit Dark and Light views do look good to my eyes... |
Collaborator
|
Yes, I think the line width increase makes it a lot more visible, and the color matches the conventions we see in iOS. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR is proposed as a solution to Loop Issue 2238: Make Checkmark List Items easier to see
Sample screen views using for this PR.